Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some warnings. #3416

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Fix some warnings. #3416

merged 1 commit into from
Oct 16, 2024
+48 −43

Conversation

pixlwave
Copy link
Member

Nothing major, just a few Swift and SwiftLint warnings.

@pixlwave pixlwave added the pr-misc for other changes label Oct 15, 2024
@pixlwave pixlwave requested a review from a team as a code owner October 15, 2024 15:44
@pixlwave pixlwave requested review from stefanceriu and removed request for a team October 15, 2024 15:44
@github-actions GitHub Actions
Copy link

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against ea70f1b

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov Codecov
Copy link

codecov bot commented Oct 15, 2024 •
edited
Loading

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
842 3 839 0
View the top 2 failed tests by shortest run time 
UserSessionFlowCoordinatorTests testRoomClearsStack()
Stack Traces | 0.839s run time 
XCTAssertTrue failed (.../UnitTests/Sources/UserSessionFlowCoordinatorTests.swift:190)

RoomScreenViewModelTests testPinnedEventsBanner()
Stack Traces | 13.5s run time 
Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Awaiting publisher". (.../Sources/Extensions/XCTestCase.swift:43)
View the full list of 1 ❄️ flaky tests 
PreviewTests test_serverSelection()

Flake rate in main: 11.83% (Passed 82 times, Failed 11 times)

Stack Traces | 1.96s run time 
failed - Snapshot does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_serverSelection-iPhone-16-pseudo.3.png"
@+
"file:.../tmp/PreviewTests/test_serverSelection-iPhone-16-pseudo.3.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.8937988 is less than required 1.0
The lowest perceptual color precision 0.29250002 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

stefanceriu
stefanceriu approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super duper nice, thank you! 🙌

@pixlwave pixlwave merged commit 718774d into develop Oct 16, 2024
13 checks passed
@pixlwave pixlwave deleted the doug/warnings branch October 16, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanceriu stefanceriu stefanceriu approved these changes

Assignees
No one assigned
Labels
pr-misc for other changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pixlwave @stefanceriu